Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: bluetooth: Add Channel Sounding Reflector with Ranging Responder sample #18894

Merged
merged 1 commit into from
Nov 18, 2024
Merged

samples: bluetooth: Add Channel Sounding Reflector with Ranging Responder sample #18894

merged 1 commit into from
Nov 18, 2024
+280 −1

Conversation

alexstanoev-nordic
Copy link
Contributor

This sample can be used to set up a Channel Sounding Reflector with the GATT Ranging Responder service.
A Channel Sounding Initiator with Ranging Requestor can connect to this sample to receive CS Ranging Data and perform distance estimation.

The corresponding initiator sample will follow shortly and will update the docs with exact path references.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 14, 2024
@alexstanoev-nordic alexstanoev-nordic requested a review from a team November 14, 2024 13:04
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: b5d96ffdc0c73ef34fd67c6f3014cedc2bca1bba

more details

sdk-nrf:

PR head: b5d96ffdc0c73ef34fd67c6f3014cedc2bca1bba
merge base: 423981109ef39b942e73e2b8e91c64692bc4d566
target head (main): f067e19ca105c5a59bcbb82b3898b9deabc080de
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
CODEOWNERS
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── channel_sounding_ras_reflector
│  │  │  ├── CMakeLists.txt
│  │  │  ├── README.rst
│  │  │  ├── prj.conf
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: f51bdba1d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f51bdba1d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 432
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@alexstanoev-nordic alexstanoev-nordic force-pushed the develop/cs_rrsp_sample branch 2 times, most recently from 07bf10d to d9e2653 Compare November 14, 2024 15:05
@alexstanoev-nordic alexstanoev-nordic force-pushed the develop/cs_rrsp_sample branch 2 times, most recently from 99663ae to 4a70e8a Compare November 15, 2024 11:18
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

peknis
peknis requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry needed.

@alexstanoev-nordic alexstanoev-nordic requested a review from a team as a code owner November 15, 2024 13:07
@alexstanoev-nordic
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system @nrfconnect/ncs-code-owners Please review

@alexstanoev-nordic
Copy link
Contributor Author

Ping @nrfconnect/ncs-co-build-system @nrfconnect/ncs-code-owners

nordicjm
nordicjm reviewed Nov 18, 2024
View reviewed changes
samples/bluetooth/channel_sounding_ras_reflector/src/main.c Outdated
{
int err;

printk("Starting Channel Sounding Reflector Sample\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace prink with LOG_* calls instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by default LOG_* and printk() use the same backend anyway. (CONFIG_LOG selects CONFIG_PRINTK => makes CONFIG_LOG_PRINTK default to y).

There's also many existing samples that use printk()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use logging now but I agree, would be nice if all the samples were consistent in their logger usage

samples/bluetooth/channel_sounding_ras_reflector/src/main.c Show resolved Hide resolved
@alexstanoev-nordic
samples: bluetooth: Add Channel Sounding Reflector with RRSP sample
b5d96ff 
This sample can be used to set up a Channel Sounding Reflector with
the GATT Ranging Responder service.
A Channel Sounding Initiator with Ranging Requestor can connect to this
sample to receive CS Ranging Data and perform distance estimation.

Signed-off-by: Aleksandar Stanoev <[email protected]>
@rlubos rlubos merged commit 59130f5 into nrfconnect:main Nov 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivier-le-sage olivier-le-sage olivier-le-sage left review comments

@sean-madigan sean-madigan sean-madigan approved these changes

@wiba-nordic wiba-nordic wiba-nordic approved these changes

@peknis peknis peknis approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alexstanoev-nordic @NordicBuilder @nordicjm @olivier-le-sage @peknis @wiba-nordic @sean-madigan @rlubos